]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
i2c: xiic: must always write 16-bit words to TX_FIFO
authorSteven A. Falco <sfalco@harris.com>
Mon, 22 Apr 2013 09:34:39 +0000 (09:34 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 8 May 2013 03:08:19 +0000 (20:08 -0700)
commit35d20c1b1a355f53e5b9f403ad57c26cd3b5d676
treeee4264f02f060bdbe04cd3a090cb756e46d4a328
parent228a8f062631a04bf383a80f30f4c9787c706ecd
i2c: xiic: must always write 16-bit words to TX_FIFO

commit c39e8e4354ce4daf23336de5daa28a3b01f00aa6 upstream.

The TX_FIFO register is 10 bits wide.  The lower 8 bits are the data to be
written, while the upper two bits are flags to indicate stop/start.

The driver apparently attempted to optimize write access, by only writing a
byte in those cases where the stop/start bits are zero.  However, we have
seen cases where the lower byte is duplicated onto the upper byte by the
hardware, which causes inadvertent stop/starts.

This patch changes the write access to the transmit FIFO to always be 16 bits
wide.

Signed off by: Steven A. Falco <sfalco@harris.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/i2c/busses/i2c-xiic.c