]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
[PATCH] bcm43xx: fix watchdog timeouts.
authorMichael Buesch <mb@bu3sch.de>
Fri, 27 Oct 2006 16:16:39 +0000 (11:16 -0500)
committerChris Wright <chrisw@sous-sol.org>
Sat, 4 Nov 2006 01:33:46 +0000 (17:33 -0800)
commit37f8d2f4d123433cd1fd2936e9bc726be0939ef0
tree9e5406ea3a5af1f6a8134b46914ea4284078b60e
parent955ebc8df7709dbcb92d7bf74a2598282e1c9307
[PATCH] bcm43xx: fix watchdog timeouts.

This fixes a netdev watchdog timeout problem.
The problem is caused by a needed netif_tx_disable
in the hardware calibration code and can be shown by the
following timegraph.

|---5secs - ~10 jiffies time---|---|OOPS
^                              ^
last real TX                   periodic work stops netif

At OOPS, the following happens:
The watchdog timer triggers, because the timeout of 5secs
is over. The watchdog first checks for stopped TX.
_Usually_ TX is only stopped from the TX handler to indicate
a full TX queue. But this is different. We need to stop TX here,
regardless of the TX queue state. So the watchdog recognizes
the stopped device and assumes it is stopped due to full
TX queues (Which is a _wrong_ assumption in this case). It then
tests how far the last TX has been in the past. If it's more than
5secs (which is the case for low or no traffic), it will fire
a TX timeout.

Acked-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Michael Buesch <mb@bu3sch.de>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
drivers/net/wireless/bcm43xx/bcm43xx_main.c