]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
rhashtable: Enforce minimum size on initial hash table
authorHerbert Xu <herbert@gondor.apana.org.au>
Wed, 16 Dec 2015 10:13:14 +0000 (18:13 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 16 Dec 2015 15:44:08 +0000 (10:44 -0500)
commit3a324606bbabfc30084ce9d08169910773ba9a92
tree3561b143a3f0c9036cd6e9b9e5e3adc95208846a
parent887dc9f2cef6e98dcccf807da5e6faf4f60ba483
rhashtable: Enforce minimum size on initial hash table

William Hua <william.hua@canonical.com> wrote:
>
> I wasn't aware there was an enforced minimum size. I simply set the
> nelem_hint in the rhastable_params struct to 1, expecting it to grow as
> needed. This caused a segfault afterwards when trying to insert an
> element.

OK we're doing the size computation before we enforce the limit
on min_size.

---8<---
We need to do the initial hash table size computation after we
have obtained the correct min_size/max_size parameters.  Otherwise
we may end up with a hash table whose size is outside the allowed
envelope.

Fixes: a998f712f77e ("rhashtable: Round up/down min/max_size to...")
Reported-by: William Hua <william.hua@canonical.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
lib/rhashtable.c