]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
ncpfs: fix a braino in OOM handling in ncp_fill_cache()
authorAl Viro <viro@zeniv.linux.org.uk>
Tue, 8 Mar 2016 03:17:07 +0000 (22:17 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 16 Mar 2016 15:42:59 +0000 (08:42 -0700)
commit3c92cc68a18238456bda23678d96e91afd9a8f6c
tree11f12b2e8a136a7fe018ec2184194fb260a4d690
parenta29fe6f3c9c25c0cf3d190e0c0667da3ef4ca611
ncpfs: fix a braino in OOM handling in ncp_fill_cache()

commit 803c00123a8012b3a283c0530910653973ef6d8f upstream.

Failing to allocate an inode for child means that cache for *parent* is
incompletely populated.  So it's parent directory inode ('dir') that
needs NCPI_DIR_CACHE flag removed, *not* the child inode ('inode', which
is what we'd failed to allocate in the first place).

Fucked-up-in: commit 5e993e25 ("ncpfs: get rid of d_validate() nonsense")
Fucked-up-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/ncpfs/dir.c