]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
iser-target: Put the reference on commands waiting for unsol data
authorJenny Derzhavetz <jennyf@mellanox.com>
Sun, 6 Sep 2015 11:52:21 +0000 (14:52 +0300)
committerNicholas Bellinger <nab@linux-iscsi.org>
Tue, 15 Sep 2015 22:47:21 +0000 (15:47 -0700)
commit3e03c4b01da3e6a5f3081eb0aa252490fe83e352
treeecf2ab459184cdafb3a8e9fa23e6e1634f3fb6e3
parenta4c15cd957cbd728f685645de7a150df5912591a
iser-target: Put the reference on commands waiting for unsol data

The iscsi target core teardown sequence calls wait_conn for
all active commands to finish gracefully by:
- move the queue-pair to error state
- drain all the completions
- wait for the core to finish handling all session commands

However, when tearing down a session while there are sequenced
commands that are still waiting for unsolicited data outs, we can
block forever as these are missing an extra reference put.

We basically need the equivalent of iscsit_free_queue_reqs_for_conn()
which is called after wait_conn has returned. Address this by an
explicit walk on conn_cmd_list and put the extra reference.

Signed-off-by: Jenny Derzhavetz <jennyf@mellanox.com>
Signed-off-by: Sagi Grimberg <sagig@mellanox.com>
Cc: <stable@vger.kernel.org> # v3.10+
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/infiniband/ulp/isert/ib_isert.c