]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
CRIS: fix I/O macros
authorCorey Minyard <cminyard@mvista.com>
Tue, 18 Dec 2012 22:21:19 +0000 (14:21 -0800)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 3 Jan 2013 03:33:43 +0000 (03:33 +0000)
commit3ee38c11281143f565f5bf1c947072a1bea06486
tree5cb3682be895d2e26f8bfbda3ef53c2e261b0dc9
parentabae184041188034d52afe07103bc0ab6662ece0
CRIS: fix I/O macros

commit c24bf9b4cc6a0f330ea355d73bfdf1dae7e63a05 upstream.

The inb/outb macros for CRIS are broken from a number of points of view,
missing () around parameters and they have an unprotected if statement
in them.  This was breaking the compile of IPMI on CRIS and thus I was
being annoyed by build regressions, so I fixed them.

Plus I don't think they would have worked at all, since the data values
were missing "&" and the outsl had a "3" instead of a "4" for the size.
From what I can tell, this stuff is not used at all, so this can't be
any more broken than it was before, anyway.

Signed-off-by: Corey Minyard <cminyard@mvista.com>
Cc: Jesper Nilsson <jesper.nilsson@axis.com>
Cc: Mikael Starvik <starvik@axis.com>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
arch/cris/include/asm/io.h