]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
pinctrl: samsung: Remove bogus irq_[un]mask from resource management
authorThomas Gleixner <tglx@linutronix.de>
Thu, 29 Jun 2017 21:33:35 +0000 (23:33 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Fri, 30 Jun 2017 13:51:42 +0000 (15:51 +0200)
commit3fa53ec2ed885b0aec3f0472e3b4a8a6f1cd748c
tree2ea166c1c43fdae1ddaa1db5920bbf1acf996919
parent09dc048d13165dff74ab4050454f9c2d715895d5
pinctrl: samsung: Remove bogus irq_[un]mask from resource management

The irq chip callbacks irq_request/release_resources() have absolutely no
business with masking and unmasking the irq.

The core code unmasks the interrupt after complete setup and masks it
before invoking irq_release_resources().

The unmask is actually harmful as it happens before the interrupt is
completely initialized in __setup_irq().

Remove it.

Fixes: f6a8249f9e55 ("pinctrl: exynos: Lock GPIOs as interrupts when used as EINTs")
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Kukjin Kim <kgene@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org
Cc: linux-gpio@vger.kernel.org
Acked-by: Tomasz Figa <tomasz.figa@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/samsung/pinctrl-exynos.c