]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
net: stmmac: fix completely hung TX when using TSO
authorNiklas Cassel <niklas.cassel@axis.com>
Tue, 6 Jun 2017 07:25:00 +0000 (09:25 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 6 Jun 2017 20:24:09 +0000 (16:24 -0400)
commit426849e6611f2092553f8d53372ae310818a6292
tree4fd24f7c67978e435247e14f5595f39cc32292e2
parentd220b942a4b6a0640aee78841608f4aa5e8e185e
net: stmmac: fix completely hung TX when using TSO

stmmac_tso_allocator can fail to set the Last Descriptor bit
on a descriptor that actually was the last descriptor.

This happens when the buffer of the last descriptor ends
up having a size of exactly TSO_MAX_BUFF_SIZE.

When the IP eventually reaches the next last descriptor,
which actually has the bit set, the DMA will hang.

When the DMA hangs, we get a tx timeout, however,
since stmmac does not do a complete reset of the IP
in stmmac_tx_timeout, we end up in a state with
completely hung TX.

Signed-off-by: Niklas Cassel <niklas.cassel@axis.com>
Acked-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Acked-by: Alexandre TORGUE <alexandre.torgue@st.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c