]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
gpio: mvebu: fix regmap_update_bits usage
authorGregory CLEMENT <gregory.clement@free-electrons.com>
Fri, 9 Jun 2017 10:09:17 +0000 (12:09 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Fri, 16 Jun 2017 09:15:20 +0000 (11:15 +0200)
commit43a2dcecd8ae16c76026d6728e072a6c0aa2d8ac
treec7c95e8a14b401bca3934a8a0b2aa9bda3a05d16
parent3638bd4a066c14256bad0b99a60821709d3807b4
gpio: mvebu: fix regmap_update_bits usage

In some place in the driver regmap_update_bits was misused. Indeed the
last argument is not the value of the bit (or group of bits) itself but
the mask value inside the register.

So when setting the bit N, then the value must be BIT(N) and not 1.

CC: Ralph Sennhauser <ralph.sennhauser@gmail.com>
Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Tested-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
Tested-by: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-mvebu.c