]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
test: firmware_class: report errors properly on failure
authorBrian Norris <computersforpeace@gmail.com>
Wed, 9 Dec 2015 22:50:25 +0000 (14:50 -0800)
committerShuah Khan <shuahkh@osg.samsung.com>
Thu, 7 Jan 2016 20:41:22 +0000 (13:41 -0700)
commit47e0bbb7fa985a0f1b5794a8653fae4f8f49de77
tree46b7522c6682e52c2869e2992502ad6b41f656fd
parentb5bb6d3068eabb075ee7db09c73374f6db73ff4a
test: firmware_class: report errors properly on failure

request_firmware() failures currently won't get reported at all (the
error code is discarded). What's more, we get confusing messages, like:

    # echo -n notafile > /sys/devices/virtual/misc/test_firmware/trigger_request
    [ 8280.311856] test_firmware: loading 'notafile'
    [ 8280.317042] test_firmware: load of 'notafile' failed: -2
    [ 8280.322445] test_firmware: loaded: 0
    # echo $?
    0

Report the failures via write() errors, and don't say we "loaded"
anything.

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Acked-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
lib/test_firmware.c