]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
serial: sh-sci: Uninitialized variables in sysfs files
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 17 Jul 2017 08:34:23 +0000 (11:34 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 17 Jul 2017 11:19:19 +0000 (13:19 +0200)
commit4ab3c51e0540ba8464fe34d84cc35821bb77ae92
tree8b0b3a1c891e7496f470cdfcdb53acc46c051d8f
parent2b01bfaeb41e1563322448d9b392ac924cbf22ef
serial: sh-sci: Uninitialized variables in sysfs files

The kstrtol() function returns -ERANGE as well as -EINVAL so these tests
are not enough.  It's not a super serious bug, but my static checker
correctly complains that the "r" variable might be used uninitialized.

Fixes: 5d23188a473d ("serial: sh-sci: make RX FIFO parameters tunable via sysfs")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/sh-sci.c