]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
ipv6: Fix OOPS in ip6_dst_lookup_tail().
authorNeil Horman <nhorman@tuxdriver.com>
Tue, 9 Sep 2008 20:51:35 +0000 (13:51 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 9 Oct 2008 02:44:44 +0000 (19:44 -0700)
commit4b37352ee6c6551bd8bea079219d352990b648ed
tree5c1b77fcef98a720332d0a5ae958891a57aec4d4
parentdcd761a24946b6721ecf3d10f1889296cdf3d6e7
ipv6: Fix OOPS in ip6_dst_lookup_tail().

[ Upstream commit e550dfb0c2c31b6363aa463a035fc9f8dcaa3c9b ]

This fixes kernel bugzilla 11469: "TUN with 1024 neighbours:
ip6_dst_lookup_tail NULL crash"

dst->neighbour is not necessarily hooked up at this point
in the processing path, so blindly dereferencing it is
the wrong thing to do.  This NULL check exists in other
similar paths and this case was just an oversight.

Also fix the completely wrong and confusing indentation
here while we're at it.

Based upon a patch by Evgeniy Polyakov.

Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/ipv6/ip6_output.c