]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
S390: Fix sysdev class file creation.
authorHeiko Carstens <heiko.carstens@de.ibm.com>
Tue, 28 Oct 2008 17:15:07 +0000 (17:15 +0000)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 7 Nov 2008 03:05:36 +0000 (19:05 -0800)
commit4c49d126ab91fdd12801e216105fa35f5a915781
treea768a6e3e3870518280a029ae809aaee3fe30712
parent5af73683b72a1d37ebb785eb4f03d9002c47e186
S390: Fix sysdev class file creation.

commit da5aae7036692fa8d03da1b705c76fd750ed9e38 upstream

Use sysdev_class_create_file() to create create sysdev class attributes
instead of sysfs_create_file(). Using sysfs_create_file() wasn't a very
good idea since the show and store functions have a different amount of
parameters for sysfs files and sysdev class files.
In particular the pointer to the buffer is the last argument and
therefore accesses to random memory regions happened.
Still worked surprisingly well until we got a kernel panic.

Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
arch/s390/kernel/smp.c