]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
cdc_ncm: do not call usbnet_link_change from cdc_ncm_bind
authorBjørn Mork <bjorn@mork.no>
Mon, 7 Mar 2016 20:15:36 +0000 (21:15 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 7 Mar 2016 20:54:33 +0000 (15:54 -0500)
commit4d06dd537f95683aba3651098ae288b7cbff8274
treedcec6c71e8c971a59085b6f26003642dd81acd58
parenta9d99ce28ed359d68cf6f3c1a69038aefedf6d6a
cdc_ncm: do not call usbnet_link_change from cdc_ncm_bind

usbnet_link_change will call schedule_work and should be
avoided if bind is failing. Otherwise we will end up with
scheduled work referring to a netdev which has gone away.

Instead of making the call conditional, we can just defer
it to usbnet_probe, using the driver_info flag made for
this purpose.

Fixes: 8a34b0ae8778 ("usbnet: cdc_ncm: apply usbnet_link_change")
Reported-by: Andrey Konovalov <andreyknvl@gmail.com>
Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Bjørn Mork <bjorn@mork.no>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/cdc_ncm.c