]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
usb: renesas_usbhs: fix to avoid using a disabled ep in usbhsg_queue_done()
authorYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Mon, 4 Apr 2016 11:40:20 +0000 (20:40 +0900)
committerFelipe Balbi <felipe.balbi@linux.intel.com>
Mon, 4 Apr 2016 12:18:48 +0000 (15:18 +0300)
commit4fccb0767fdbdb781a9c5b5c15ee7b219443c89d
treea8b5397bdd5d8ba5bd41c16e51674ec91fd4e4bf
parentecd9a7ad453c5effc9a26355b79ee83f1337cba4
usb: renesas_usbhs: fix to avoid using a disabled ep in usbhsg_queue_done()

This patch fixes an issue that usbhsg_queue_done() may cause kernel
panic when dma callback is running and usb_ep_disable() is called
by interrupt handler. (Especially, we can reproduce this issue using
g_audio with usb-dmac driver.)

For example of a flow:
 usbhsf_dma_complete (on tasklet)
  --> usbhsf_pkt_handler (on tasklet)
   --> usbhsg_queue_done (on tasklet)
    *** interrupt happened and usb_ep_disable() is called ***
    --> usbhsg_queue_pop (on tasklet)
     Then, oops happened.

Fixes: e73a989 ("usb: renesas_usbhs: add DMAEngine support")
Cc: <stable@vger.kernel.org> # v3.1+
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
drivers/usb/renesas_usbhs/mod_gadget.c