]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
rtc: ds1307: fix kernel splat due to wakeup irq handling
authorFelipe Balbi <balbi@ti.com>
Wed, 11 Nov 2015 16:11:01 +0000 (10:11 -0600)
committerAlexandre Belloni <alexandre.belloni@free-electrons.com>
Wed, 25 Nov 2015 11:15:44 +0000 (12:15 +0100)
commit51c4cfef568fe8ebac06761ed7c754fac1f9b5a8
treea6e1eb502275cde0c9b3589459d7edd70ca8c81f
parent1ec218373b8ebda821aec00bb156a9c94fad9cd4
rtc: ds1307: fix kernel splat due to wakeup irq handling

Since commit 3fffd1283927 ("i2c: allow specifying
separate wakeup interrupt in device tree") we have
automatic wakeup irq support for i2c devices. That
commit missed the fact that rtc-1307 had its own
wakeup irq handling and ended up introducing a
kernel splat for at least Beagle x15 boards.

Fix that by reverting original commit _and_ passing
correct interrupt names on DTS so i2c-core can
choose correct IRQ as wakeup.

Now that we have automatic wakeirq support, we can
revert the original commit which did it manually.

Fixes the following warning:

[   10.346582] WARNING: CPU: 1 PID: 263 at linux/drivers/base/power/wakeirq.c:43 dev_pm_attach_wake_irq+0xbc/0xd4()
[   10.359244] rtc-ds1307 2-006f: wake irq already initialized

Cc: Tony Lindgren <tony@atomide.com>
Cc: Nishanth Menon <nm@ti.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Acked-by: Tony Lindgren <tony@atomide.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
arch/arm/boot/dts/am57xx-beagle-x15.dts
drivers/rtc/rtc-ds1307.c