]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
sctp: correct bounds check in sctp_setsockopt_auth_key
authorVlad Yasevich <vladislav.yasevich@hp.com>
Wed, 3 Sep 2008 08:02:19 +0000 (01:02 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 8 Sep 2008 11:44:25 +0000 (04:44 -0700)
commit53144b419e176e51157f6b9fc651ab9e733cb000
tree3bd9d54a8aad8ec89716ccbf8679870b441e43e1
parent97348238e1f470b200d4b810becaaa4147c6db51
sctp: correct bounds check in sctp_setsockopt_auth_key

[ Upstream commit 328fc47ea0bcc27d9afa69c3ad6e52431cadd76c ]

The bonds check to prevent buffer overlflow was not exactly
right.  It still allowed overflow of up to 8 bytes which is
sizeof(struct sctp_authkey).

Since optlen is already checked against the size of that struct,
we are guaranteed not to cause interger overflow either.

Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/sctp/socket.c