]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
x86-64: Clean up save/restore_i387() usage
authorLinus Torvalds <torvalds@linux-foundation.org>
Wed, 1 Oct 2008 00:56:12 +0000 (17:56 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 9 Oct 2008 03:22:54 +0000 (20:22 -0700)
commit568fc52e4917a0bfb0ac8b54eb8636f9e51886c1
tree4ddcd43badc3e2bdd45bb4c58d918fdb6b6ba381
parent689f18f9c2e72b4b8589b055a51ff7bc7ffbd5bd
x86-64: Clean up save/restore_i387() usage

[ Upstream commit b30f3ae50cd03ef2ff433a5030fbf88dd8323528]

Suresh Siddha wants to fix a possible FPU leakage in error conditions,
but the fact that save/restore_i387() are inlines in a header file makes
that harder to do than necessary.  So start off with an obvious cleanup.

This just moves the x86-64 version of save/restore_i387() out of the
header file, and moves it to the only file that it is actually used in:
arch/x86/kernel/signal_64.c.  So exposing it in a header file was wrong
to begin with.

[ Side note: I'd like to fix up some of the games we play with the
  32-bit version of these functions too, but that's a separate
  matter.  The 32-bit versions are shared - under different names
  at that! - by both the native x86-32 code and the x86-64 32-bit
  compatibility code ]

Acked-by: Suresh Siddha <suresh.b.siddha@intel.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
arch/x86/kernel/signal_64.c
include/asm-x86/i387.h