]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
ext4: remove erroneous ext4_superblock_csum_set() in update_backups()
authorTao Ma <boyu.mt@taobao.com>
Thu, 20 Sep 2012 15:35:38 +0000 (11:35 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 3 Dec 2012 19:38:15 +0000 (11:38 -0800)
commit5770e9ed8a5b8ae7204e6cfe52565f10395091e4
tree4d586674e5732c554b2f123a6861cb2666fd114a
parent5433889db1b04159054a9e6357f90c77970cf4ed
ext4: remove erroneous ext4_superblock_csum_set() in update_backups()

commit bef53b01faeb791e27605cba1a71ba21364cb23e upstream.

The update_backups() function is used to backup all the metadata
blocks, so we should not take it for granted that 'data' is pointed to
a super block and use ext4_superblock_csum_set to calculate the
checksum there.  In case where the data is a group descriptor block,
it will corrupt the last group descriptor, and then e2fsck will
complain about it it.

As all the metadata checksums should already be OK when we do the
backup, remove the wrong ext4_superblock_csum_set and it should be
just fine.

Reported-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Tao Ma <boyu.mt@taobao.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/ext4/resize.c