]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
l2tp: fix oops in l2tp_eth_create() error path
authorTom Parkin <tparkin@katalix.com>
Mon, 29 Oct 2012 23:41:48 +0000 (23:41 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 17 Nov 2012 21:14:25 +0000 (13:14 -0800)
commit5a3e425d67aab6b6f0b3bd3fb372b8044b8e981b
treead81ab86f5ba8b81660d53ef46f47f6e57657a8e
parent798c7dba9071df9cdd935da16066e1a17580d9ee
l2tp: fix oops in l2tp_eth_create() error path

[ Upstream commit 789336360e0a2aeb9750c16ab704a02cbe035e9e ]

When creating an L2TPv3 Ethernet session, if register_netdev() should fail for
any reason (for example, automatic naming for "l2tpeth%d" interfaces hits the
32k-interface limit), the netdev is freed in the error path.  However, the
l2tp_eth_sess structure's dev pointer is left uncleared, and this results in
l2tp_eth_delete() then attempting to unregister the same netdev later in the
session teardown.  This results in an oops.

To avoid this, clear the session dev pointer in the error path.

Signed-off-by: Tom Parkin <tparkin@katalix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/l2tp/l2tp_eth.c