]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
dynamic debug: move ddebug_remove_module() down into free_module()
authorJason Baron <jbaron@redhat.com>
Tue, 27 Jul 2010 20:18:01 +0000 (13:18 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 2 Aug 2010 17:26:32 +0000 (10:26 -0700)
commit5a584f5f76f8dd3b22de43d5e6f4c5d3fba99ba3
tree0c531fadd8e38290ab3864e8e9f5676317037775
parent2d6be56934d885c0ede350f52bcc1d1718ed8cd7
dynamic debug: move ddebug_remove_module() down into free_module()

commit b82bab4bbe9efa7bc7177fc20620fff19bd95484 upstream.

The command

echo "file ec.c +p" >/sys/kernel/debug/dynamic_debug/control

causes an oops.

Move the call to ddebug_remove_module() down into free_module().  In this
way it should be called from all error paths.  Currently, we are missing
the remove if the module init routine fails.

Signed-off-by: Jason Baron <jbaron@redhat.com>
Reported-by: Thomas Renninger <trenn@suse.de>
Tested-by: Thomas Renninger <trenn@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
kernel/module.c