]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
mv643xx_eth: fix unicast filter programming in promiscuous mode
authorPrabhanjan Sarnaik <sarnaik@marvell.com>
Thu, 18 Jun 2009 11:35:02 +0000 (11:35 +0000)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 2 Jul 2009 23:50:28 +0000 (16:50 -0700)
commit5bbc754a8a4857eb09ebcfc5afe9fb6b59b75291
tree474e768209211b18c756a8cebe95dc83182dcdf1
parent69f1d553612091ec022a660c0ca58f98fe4e184c
mv643xx_eth: fix unicast filter programming in promiscuous mode

commit 6877f54e6a3326c99aaf84b7bff6a3019da0b847 upstream.

The Unicast Promiscious Mode (UPM) bit in the mv643xx_eth port
configuration register doesn't do exactly what its name would suggest:
setting this bit merely enables reception of all unicast frames with a
destination address that differs from our local MAC address in bits
[47:4].  In particular, it doesn't have any effect on unicast frames
with a destination address that matches our MAC address in bits [47:4]
-- these will still be tested against the 16-entry unicast address
filter table.

Therefore, if the interface is set to promiscuous mode, just setting
the unicast promiscuous bit isn't enough -- we need to set all filter
bits in the unicast filter table to 1 as well.

Reported-by: Sachin Sanap <ssanap@marvell.com>
Signed-off-by: Prabhanjan Sarnaik <sarnaik@marvell.com>
Tested-by: Siddarth Gore <gores@marvell.com>
Tested-by: Mahavir Jain <mjain@marvell.com>
Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/net/mv643xx_eth.c