]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
perf hists: Fix children sort key behavior
authorNamhyung Kim <namhyung@kernel.org>
Tue, 23 Dec 2014 04:36:21 +0000 (13:36 +0900)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 8 Jan 2015 14:26:56 +0000 (11:26 -0300)
commit5ca8271022da8583f0d618aeda5b2bae785e7882
tree4bda325a1b225d454049cbf638c53ce38999df24
parented9eb845d7916b2bc863e5b93c82e18be8faf032
perf hists: Fix children sort key behavior

When perf report --children resorts output fields, it tries to put
caller above the callee.  But this was only meaningful for a same thread
and doing this requires callchain enabled.  So fix its check before
comparing the callchain depth.

This also changes the hist accumulation tests: In test 3, xmalloc in
bash thread should be above than other perf threads due to alphabetical
order of comm string.  Also it's under page_fault in bash thread since
alphabetical order of dso name.  The sys_perf_event_open in perf thread
is put on the last line since it's self overhead is 0.

In test 4, the sys_perf_event_open is put above other perf entries that
have same children overhead since its callchain depth is smaller.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1419309381-2593-1-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/tests/hists_cumulate.c
tools/perf/ui/hist.c