]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
coredump: prevent double-free on an error path in core dumper
authorDenys Vlasenko <vda.linux@googlemail.com>
Thu, 13 Sep 2012 01:01:27 +0000 (11:01 +1000)
committerStephen Rothwell <sfr@canb.auug.org.au>
Thu, 13 Sep 2012 07:28:16 +0000 (17:28 +1000)
commit624cd49e04be38db98e8449a18587eb59e590e04
treebe0f32062472b98760e32493742ee1f4153b32aa
parentce262175e22733d46235d258deabf6af49beab6e
coredump: prevent double-free on an error path in core dumper

In !CORE_DUMP_USE_REGSET case, if elf_note_info_init fails to allocate
memory for info->fields, it frees already allocated stuff and returns
error to its caller, fill_note_info.  Which in turn returns error to its
caller, elf_core_dump.  Which jumps to cleanup label and calls
free_note_info, which will happily try to free all info->fields again.
BOOM.

This is the fix.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Cc: Venu Byravarasu <vbyravarasu@nvidia.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
fs/binfmt_elf.c