]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
nfs: Fix NFS v4 client handling of MAY_EXEC in nfs_permission.
authorFrank Filz <ffilzlnx@us.ibm.com>
Mon, 18 May 2009 21:41:40 +0000 (17:41 -0400)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 15 Jun 2009 16:39:59 +0000 (09:39 -0700)
commit63eef0d3d33a89540e62207742118a6567bd4795
tree09f8e022c4f15a389463a2440c2c2bb1f27bc336
parent7e3ab8deaa79f69dc99ce624f3cc857e746d62d4
nfs: Fix NFS v4 client handling of MAY_EXEC in nfs_permission.

commit 7ee2cb7f32b299c2b06a31fde155457203e4b7dd upstream.

The problem is that permission checking is skipped if atomic open is
possible, but when exec opens a file, it just opens it O_READONLY which
means EXEC permission will not be checked at that time.

This problem is observed by the following sequence (executed as root):

  mount -t nfs4 server:/ /mnt4
  echo "ls" >/mnt4/foo
  chmod 744 /mnt4/foo
  su guest -c "mnt4/foo"

Signed-off-by: Frank Filz <ffilzlnx@us.ibm.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Tested-by: Eugene Teo <eugeneteo@kernel.sg>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
fs/nfs/dir.c