]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
netdrvr: atl1e: Don't take the mdio_lock in atl1e_probe
authorMatthew Wilcox <matthew@wil.cx>
Tue, 12 Aug 2008 13:13:14 +0000 (07:13 -0600)
committerGreg Kroah-Hartman <gregkh@suse.de>
Sat, 18 Oct 2008 17:49:13 +0000 (10:49 -0700)
commit6505670551fa3deeb6e5d7cab6983514384c7220
tree989c477b658e762fd4bb0b7872a0180f0fd69692
parent0018d3e671060d5576fe99a2fe1985db4b1ea946
netdrvr: atl1e: Don't take the mdio_lock in atl1e_probe

commit f382a0a8e9403c6d7f8b2cfa21e41fefb5d0c9bd upstream

Lockdep warns about the mdio_lock taken with interrupts enabled then later
taken from interrupt context.  Initially, I considered changing these
to spin_lock_irq/spin_unlock_irq, but then I looked at atl1e_phy_init()
and saw that it calls msleep().  Sleeping while holding a spinlock is
not allowed either.

In the probe path, we haven't registered the interrupt handler, so
it can't poke at this card yet.  It's before we call register_netdev(),
so I don't think any other threads can reach this card either.  If I'm
right, we don't need a spinlock at all.

Signed-off-by: Matthew Wilcox <willy@linux.intel.com>
Cc: Jay Cliburn <jacliburn@bellsouth.net>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/net/atl1e/atl1e_main.c