]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
ipr: Fix regression when loading firmware
authorGabriel Krisman Bertazi <krisman@linux.vnet.ibm.com>
Thu, 25 Feb 2016 16:54:20 +0000 (13:54 -0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 12 Apr 2016 16:08:58 +0000 (09:08 -0700)
commit6677a2ab036f28134b60ad4ed6fd2e72db579b8a
treeb65b237eab03f49add7df491719f594244d4bef8
parenta918d2bcea6aab6e671bfb0901cbecc3cf68fca1
ipr: Fix regression when loading firmware

commit 21b81716c6bff24cda52dc75588455f879ddbfe9 upstream.

Commit d63c7dd5bcb9 ("ipr: Fix out-of-bounds null overwrite") removed
the end of line handling when storing the update_fw sysfs attribute.
This changed the userpace API because it started refusing writes
terminated by a line feed, which broke the update tools we already have.

This patch re-adds that handling, so both a write terminated by a line
feed or not can make it through with the update.

Fixes: d63c7dd5bcb9 ("ipr: Fix out-of-bounds null overwrite")
Signed-off-by: Gabriel Krisman Bertazi <krisman@linux.vnet.ibm.com>
Cc: Insu Yun <wuninsu@gmail.com>
Acked-by: Brian King <brking@linux.vnet.ibm.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Cc: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/scsi/ipr.c