]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
spi: spi_write_then_read() bugfixes
authorDavid Brownell <dbrownell@users.sourceforge.net>
Mon, 13 Apr 2009 22:35:03 +0000 (22:35 +0000)
committerChris Wright <chrisw@sous-sol.org>
Mon, 27 Apr 2009 17:37:00 +0000 (10:37 -0700)
commit68890fb0bae12f076377dd6a9371be0289b98b7b
tree1ed2e23d94f4431c0f740758e98f2329a3fc2d10
parentd11a29e323dfd141183cdc918e31acdff02ef450
spi: spi_write_then_read() bugfixes

upstream commit: bdff549ebeff92b1a6952e5501caf16a6f8898c8

The "simplify spi_write_then_read()" patch included two regressions from
the 2.6.27 behaviors:

 - The data it wrote out during the (full duplex) read side
   of the transfer was not zeroed.

 - It fails completely on half duplex hardware, such as
   Microwire and most "3-wire" SPI variants.

So, revert that patch.  A revised version should be submitted at some
point, which can get the speedup on standard hardware (full duplex)
without breaking on less-capable half-duplex stuff.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Cc: <stable@kernel.org> [2.6.28.x, 2.6.29.x]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
drivers/spi/spi.c