]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
cfq-iosched: handle failure of cfq group allocation
authorKonstantin Khlebnikov <khlebnikov@yandex-team.ru>
Mon, 9 Feb 2015 13:42:49 +0000 (16:42 +0300)
committerJens Axboe <axboe@fb.com>
Mon, 9 Feb 2015 17:22:39 +0000 (10:22 -0700)
commit69abaffec7d47a083739b79e3066cb3730eba72e
treee217ce01355ab8b2ca1d58c54c983fda70e026f2
parent9f9ee1f2b2f94f19437ae2def7c0d6636d7fe02e
cfq-iosched: handle failure of cfq group allocation

Cfq_lookup_create_cfqg() allocates struct blkcg_gq using GFP_ATOMIC.
In cfq_find_alloc_queue() possible allocation failure is not handled.
As a result kernel oopses on NULL pointer dereference when
cfq_link_cfqq_cfqg() calls cfqg_get() for NULL pointer.

Bug was introduced in v3.5 in commit cd1604fab4f9 ("blkcg: factor
out blkio_group creation"). Prior to that commit cfq group lookup
had returned pointer to root group as fallback.

This patch handles this error using existing fallback oom_cfqq.

Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Acked-by: Tejun Heo <tj@kernel.org>
Acked-by: Vivek Goyal <vgoyal@redhat.com>
Fixes: cd1604fab4f9 ("blkcg: factor out blkio_group creation")
Cc: stable@kernel.org
Signed-off-by: Jens Axboe <axboe@fb.com>
block/cfq-iosched.c