]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
nvme_fc: fix error recovery on link down.
authorJames Smart <jsmart2021@gmail.com>
Thu, 22 Jun 2017 00:43:21 +0000 (17:43 -0700)
committerJens Axboe <axboe@kernel.dk>
Wed, 28 Jun 2017 14:14:13 +0000 (08:14 -0600)
commit69fa964632fe18a11a80ead0d09ef3399b08144a
tree51a5bcf047795d11fe60fb7977a2037599fc5f94
parent188f7e8a3789cb2e37b68903e0a40f406091fa97
nvme_fc: fix error recovery on link down.

Currently, the fc transport invokes nvme_fc_error_recovery() on every
io in which the transport detects an error.  Which means:
a) it's really noisy on large io loads that all get hit by a link down.
b) we repeatively call nvme_stop_queues() even though queues are
 stopped upon the first error or as first steps of reset_work.

Correct by:
Errors are only meaningful if the controller is in the LIVE state.
Thus, enact the reset_work only if LIVE. If called repeatively, state
will have already transitioned.
There's no need to stop the queues here. Let the first steps of
reset_work do the queue stopping.

Signed-off-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/nvme/host/fc.c