]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
staging: quatech_usb2: Potential lost wakeup scenario in TIOCMIWAIT
authorKautuk Consul <consul.kautuk@gmail.com>
Wed, 14 Sep 2011 03:26:21 +0000 (08:56 +0530)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 7 Nov 2011 20:32:15 +0000 (12:32 -0800)
commit705cec330973ff726e5c8421a7c96a7348aa6da0
treedb3d366972726a587d0abc473c7fb855a429b7e1
parent72760fea8e88dac78985e6f493c1f86b90c1fc0d
staging: quatech_usb2: Potential lost wakeup scenario in TIOCMIWAIT

commit e8df1674d383d2ecc6efa8d7dba74c03aafdfdd7 upstream.

If the usermode app does an ioctl over this serial device  by
using TIOCMIWAIT, then the code will wait by setting the current
task state to TASK_INTERRUPTIBLE and then calling schedule().
This will be woken up by the qt2_process_modem_status on URB
completion when the port_extra->shadowMSR is set to the new
modem status.

However, this could result in a lost wakeup scenario due to a race
in the logic in the qt2_ioctl(TIOCMIWAIT) loop and the URB completion
for new modem status in qt2_process_modem_status.
Due to this, the usermode app's task will continue to sleep despite a
change in the modem status.

Signed-off-by: Kautuk Consul <consul.kautuk@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/quatech_usb2/quatech_usb2.c