]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
ext4: Implement range_cyclic in ext4_da_writepages instead of write_cache_pages
authorAneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Fri, 28 May 2010 19:27:23 +0000 (14:27 -0500)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 5 Jul 2010 18:08:46 +0000 (11:08 -0700)
commit70635511aad7493f7748aa4e42dd852dfc0eb73f
tree0dc90ddc96573763143c6470bf48cbf29024ab65
parentf4a4420cd056a7dcc4134dd6df6314d0960ba39f
ext4: Implement range_cyclic in ext4_da_writepages instead of write_cache_pages

commit 2acf2c261b823d9d9ed954f348b97620297a36b5 upstream.

With delayed allocation we lock the page in write_cache_pages() and
try to build an in memory extent of contiguous blocks.  This is needed
so that we can get large contiguous blocks request.  If range_cyclic
mode is enabled, write_cache_pages() will loop back to the 0 index if
no I/O has been done yet, and try to start writing from the beginning
of the range.  That causes an attempt to take the page lock of lower
index page while holding the page lock of higher index page, which can
cause a dead lock with another writeback thread.

The solution is to implement the range_cyclic behavior in
ext4_da_writepages() instead.

http://bugzilla.kernel.org/show_bug.cgi?id=12579

Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Jayson R. King <dev@jaysonking.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
fs/ext4/inode.c