]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
mm/nommu.c: drop unlikely inside BUG_ON()
authorGeliang Tang <geliangtang@163.com>
Wed, 21 Oct 2015 22:03:13 +0000 (09:03 +1100)
committerStephen Rothwell <sfr@canb.auug.org.au>
Wed, 21 Oct 2015 22:03:13 +0000 (09:03 +1100)
commit708113fbd7053b3bf1128d829c9906dd6130c948
treeefdf0a2559187fbae7ef67f0f5453d3a580435e2
parent1725fbbb905f5ede8e4664741df926dd7e509221
mm/nommu.c: drop unlikely inside BUG_ON()

(1) For !CONFIG_BUG cases, the bug call is a no-op, so we couldn't
    care less and the change is ok.

(2) ppc and mips, which HAVE_ARCH_BUG_ON, do not rely on branch
    predictions as it seems to be pointless[1] and thus callers should not
    be trying to push an optimization in the first place.

(3) For CONFIG_BUG and !HAVE_ARCH_BUG_ON cases, BUG_ON() contains an
    unlikely compiler flag already.

Hence, we can drop unlikely behind BUG_ON().

[1] http://lkml.iu.edu/hypermail/linux/kernel/1101.3/02289.html

Signed-off-by: Geliang Tang <geliangtang@163.com>
Acked-by: Davidlohr Bueso <dave@stgolabs.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/nommu.c