]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
SCSI: aacraid: Eliminate use after free
authorJulia Lawall <julia@diku.dk>
Sat, 15 May 2010 09:46:12 +0000 (11:46 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 2 Aug 2010 17:26:35 +0000 (10:26 -0700)
commit728ce4de24301efd49417c8ead667f2e906bc6b3
tree074bdaa7031e5e50d0ddd1f47f4db4b0a194828c
parent14312cc5aab87a27d9064da50af4192743c1cedf
SCSI: aacraid: Eliminate use after free

commit 8a52da632ceb9d8b776494563df579e87b7b586b upstream.

The debugging code using the freed structure is moved before the kfree.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@free@
expression E;
position p;
@@
kfree@p(E)

@@
expression free.E, subE<=free.E, E1;
position free.p;
@@

  kfree@p(E)
  ...
(
  subE = E1
|
* E
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
drivers/scsi/aacraid/commctrl.c