]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
char: moxa, prevent opening unavailable ports
authorDirk Eibach <eibach@gdsys.de>
Thu, 18 Jun 2009 23:49:15 +0000 (16:49 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 2 Jul 2009 23:31:28 +0000 (16:31 -0700)
commit72f08ac8548b7cfb1f280340f40cc8ae702612b3
tree1829342fc94c597e49970136f75ed5c1b84e0b7f
parent442427fba55fa4d8c6a53913feb752ecf137984c
char: moxa, prevent opening unavailable ports

commit a90b037583d5f1ae3e54e9c687c79df82d1d34a4 upstream.

In moxa.c there are 32 minor numbers reserved for each device.  The number
of ports actually available per device is stored in
moxa_board_conf->numPorts.  This number is not considered in moxa_open().
Opening a port that is not available results in a kernel oops.  This patch
adds a test to moxa_open() that prevents opening unavailable ports.

[akpm@linux-foundation.org: avoid multiple returns]
Signed-off-by: Dirk Eibach <eibach@gdsys.de>
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/char/moxa.c