]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
ocfs2: Use ERR_CAST() to avoid cross-structure cast
authorKees Cook <keescook@chromium.org>
Mon, 8 May 2017 21:49:27 +0000 (14:49 -0700)
committerKees Cook <keescook@chromium.org>
Sun, 28 May 2017 17:11:49 +0000 (10:11 -0700)
commit7585d12f6555fdf4faaefec34ac58b28555b27d0
treeb9b1636760cab17d4cc8b5071843c8d48c0d5a9e
parentfee2aa753823860f2b8dfe58d98cafe8e4840855
ocfs2: Use ERR_CAST() to avoid cross-structure cast

When trying to propagate an error result, the error return path attempts
to retain the error, but does this with an open cast across very different
types, which the upcoming structure layout randomization plugin flags as
being potentially dangerous in the face of randomization. This is a false
positive, but what this code actually wants to do is use ERR_CAST() to
retain the error value.

Cc: Mark Fasheh <mfasheh@versity.com>
Cc: Joel Becker <jlbec@evilplan.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
fs/ocfs2/export.c