]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
ext4: Fix block zeroing when punching holes in indirect block files
authorJan Kara <jack@suse.cz>
Thu, 26 Jun 2014 16:28:57 +0000 (12:28 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Thu, 26 Jun 2014 16:28:57 +0000 (12:28 -0400)
commit77ea2a4ba657a1ad4fb7c64bc5cdce84b8a132b6
tree685cfe8f3bb5e96a2be066a88065bf762928a559
parente43bb4e612b402a631bc549ac496f78bc7a79438
ext4: Fix block zeroing when punching holes in indirect block files

free_holes_block() passed local variable as a block pointer
to ext4_clear_blocks(). Thus ext4_clear_blocks() zeroed out this local
variable instead of proper place in inode / indirect block. We later
zero out proper place in inode / indirect block but don't dirty the
inode / buffer again which can lead to subtle issues (some changes e.g.
to inode can be lost).

Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/indirect.c