]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
powerpc/powernv/idle: Disable LOSE_FULL_CONTEXT states when stop-api fails
authorGautham R. Shenoy <ego@linux.vnet.ibm.com>
Tue, 8 Aug 2017 08:43:15 +0000 (14:13 +0530)
committerMichael Ellerman <mpe@ellerman.id.au>
Tue, 8 Aug 2017 10:21:23 +0000 (20:21 +1000)
commit785a12afdb4a52903447fd890633c82fdda4b6f7
treed91beb5aff31b950f8a2620306e70117c173976f
parent44a12806d010944a5727f1dc99123121e3e2c8c6
powerpc/powernv/idle: Disable LOSE_FULL_CONTEXT states when stop-api fails

Currently, we use the opal call opal_slw_set_reg() to inform the
Sleep-Winkle Engine (SLW) to restore the contents of some of the
Hypervisor state on wakeup from deep idle states that lose full
hypervisor context (characterized by the flag
OPAL_PM_LOSE_FULL_CONTEXT).

However, the current code has a bug in that if opal_slw_set_reg()
fails, we don't disable the use of these deep states (winkle on
POWER8, stop4 onwards on POWER9).

This patch fixes this bug by ensuring that if programing the
sleep-winkle engine to restore the hypervisor states in
pnv_save_sprs_for_deep_states() fails, then we exclude such states by
clearing the OPAL_PM_LOSE_FULL_CONTEXT flag from
supported_cpuidle_states. As a result POWER8 will be prevented from
using winkle for CPU-Hotplug, and POWER9 will put the offlined CPUs to
the default stop state when available.

Further, we ensure in the initialization of the cpuidle-powernv driver
to only include those states whose flags are present in
supported_cpuidle_states, thereby skipping OPAL_PM_LOSE_FULL_CONTEXT
states when they have been disabled due to stop-api failure.

Fixes: 1e1601b38e6 ("powerpc/powernv/idle: Restore SPRs for deep idle
states via stop API.")

Signed-off-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/platforms/powernv/idle.c
drivers/cpuidle/cpuidle-powernv.c