]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
drm/radeon: forbid mapping of userptr bo through radeon device file
authorJérôme Glisse <jglisse@redhat.com>
Tue, 19 Apr 2016 13:07:50 +0000 (09:07 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 4 May 2016 21:48:46 +0000 (14:48 -0700)
commit7946284184695f2ba338b5c8c45a40f0b732fb2a
treed4f861f560bb73f61ef8c86f73d5f29608bc9f1d
parent2ae4d4093977f2f29af5c92d6e0627eca3a97e20
drm/radeon: forbid mapping of userptr bo through radeon device file

commit b5dcec693f87cb8475f2291c0075b2422addd3d6 upstream.

Allowing userptr bo which are basicly a list of page from some vma
(so either anonymous page or file backed page) would lead to serious
corruption of kernel structures and counters (because we overwrite
the page->mapping field when mapping buffer).

This will already block if the buffer was populated before anyone does
try to mmap it because then TTM_PAGE_FLAG_SG would be set in in the
ttm_tt flags. But that flag is check before ttm_tt_populate in the ttm
vm fault handler.

So to be safe just add a check to verify_access() callback.

Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Jérôme Glisse <jglisse@redhat.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpu/drm/radeon/radeon_ttm.c