]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
mtd: nand: check ecc->total sanity in nand_scan_tail
authorMasahiro Yamada <yamada.masahiro@socionext.com>
Thu, 25 May 2017 04:50:20 +0000 (13:50 +0900)
committerBoris Brezillon <boris.brezillon@free-electrons.com>
Thu, 1 Jun 2017 08:09:35 +0000 (10:09 +0200)
commit79e0348c4e24fd1affdcf055e0269755580e0fcc
tree1f2feb76d0f444962a23c5f68e4074d92573ce37
parent2165c4a1f71a04c7ea6493f18740a3afd4e47e4f
mtd: nand: check ecc->total sanity in nand_scan_tail

Drivers are supposed to set correct ecc->{size,strength,bytes} before
calling nand_scan_tail(), but it does not complain about ecc->total
bigger than oobsize.

In this case, chip->scan_bbt() crashes due to memory corruption, but
it is hard to debug.  It would be kind to fail it earlier with a clear
message.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
drivers/mtd/nand/nand_base.c