]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
Fix up over-eager 'wait_queue_t' renaming
authorLinus Torvalds <torvalds@linux-foundation.org>
Mon, 10 Jul 2017 18:40:19 +0000 (11:40 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Mon, 10 Jul 2017 18:40:19 +0000 (11:40 -0700)
commit7cee9384cb3e25de33d75ecdbf08bb15b4ea9fa5
tree3c83a2adc99f6d9783219f7e5d76b2ab230e5f53
parent9eb788800510ae1a6bc419636a66071ee4deafd5
Fix up over-eager 'wait_queue_t' renaming

Commit ac6424b981bc ("sched/wait: Rename wait_queue_t =>
wait_queue_entry_t") had scripted the renaming incorrectly, and didn't
actually check that the 'wait_queue_t' was a full token.

As a result, it also triggered on 'wait_queue_token', and renamed that
to 'wait_queue_entry_token' entry in the autofs4 packet structure
definition too.  That was entirely incorrect, and not intended.

The end result built fine when building just the kernel - because
everything had been renamed consistently there - but caused problems in
user space because the "struct autofs_packet_missing" type is exported
as part of the uapi.

This scripts it all back again:

    git grep -lw wait_queue_entry_token |
        xargs sed -i 's/wait_queue_entry_token/wait_queue_token/g'

and checks the end result.

Reported-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Ingo Molnar <mingo@kernel.org>
Fixes: ac6424b981bc ("sched/wait: Rename wait_queue_t => wait_queue_entry_t")
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Documentation/filesystems/autofs4.txt
fs/autofs4/autofs_i.h
fs/autofs4/waitq.c
include/uapi/linux/auto_fs.h
include/uapi/linux/auto_fs4.h