]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
i2c: cadance: fix ctrl/addr reg write order
authorMatt Weber <matthew.weber@rockwellcollins.com>
Thu, 22 Jun 2017 20:00:33 +0000 (15:00 -0500)
committerWolfram Sang <wsa@the-dreams.de>
Fri, 23 Jun 2017 18:56:21 +0000 (20:56 +0200)
commit8064c616984eaa015f018dba595d78cd24a0cc8c
treef5786d9aac081c10a277b5d1a7c7060f9c5ea181
parent9615a01f71ca02858f5265b1b545280758562aa2
i2c: cadance: fix ctrl/addr reg write order

The driver was clearing the hold bit in the control register before
writing to the address register which resulted in a stop condition
being generated rather than a repeated start.

This issue was only observed when a system was running much
slower than a normal processor would execute.  The IP data sheet
mentions a ordering of writing to the address register before
clearing the hold.

Fixes: df8eb5691c4 ("i2c: Add driver for Cadence I2C controller")
Signed-off-by: John Linn <john.linn@xilinx.com>
Signed-off-by: Paresh Chaudhary <paresh.chaudhary@rockwellcollins.com>
Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
drivers/i2c/busses/i2c-cadence.c