]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
ALSA: seq: Fix race at closing in virmidi driver
authorTakashi Iwai <tiwai@suse.de>
Mon, 1 Feb 2016 11:06:42 +0000 (12:06 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Feb 2016 20:30:59 +0000 (12:30 -0800)
commit80f6a124a398b6e08ee86d3253dd461cfff85fe3
treee8970fad63ec72db364060f0573f4bfc2d3111a2
parent3ed5d283254aab50d90525d8ea4dd713aac08d1d
ALSA: seq: Fix race at closing in virmidi driver

commit 2d1b5c08366acd46c35a2e9aba5d650cb5bf5c19 upstream.

The virmidi driver has an open race at closing its assigned rawmidi
device, and this may lead to use-after-free in
snd_seq_deliver_single_event().

Plug the hole by properly protecting the linked list deletion and
calling in the right order in snd_virmidi_input_close().

BugLink: http://lkml.kernel.org/r/CACT4Y+Zd66+w12fNN85-425cVQT=K23kWbhnCEcMB8s3us-Frw@mail.gmail.com
Reported-by: Dmitry Vyukov <dvyukov@google.com>
Tested-by: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/core/seq/seq_virmidi.c