]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
sata_nv: fix generic, nf2/3 detection regression
authorTejun Heo <tj@kernel.org>
Mon, 3 Nov 2008 03:37:49 +0000 (12:37 +0900)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 7 Nov 2008 03:05:51 +0000 (19:05 -0800)
commit814eb57e1799337d9fbb68f5d838afa507dc014e
tree5159fb3d1cabc74c730206b8c4cb8afdd0095233
parent7bee179aa2a63087ff80bdd7dcb8bd6da209f359
sata_nv: fix generic, nf2/3 detection regression

commit 3c324283e6cdb79210cf7975c3e40d3ba3e672b2 upstream

All three flavors of sata_nv's are different in how their hardreset
behaves.

* generic: Hardreset is not reliable.  Link often doesn't come online
  after hardreset.

* nf2/3: A little bit better - link comes online with longer debounce
  timing.  However, nf2/3 can't reliable wait for the first D2H
  Register FIS, so it can't wait for device readiness or classify the
  device after hardreset.  Follow-up SRST required.

* ck804: Hardreset finally works.

The core layer change to prefer hardreset and follow up changes
exposed the above issues and caused various detection regressions for
all three flavors.  This patch, hopefully, fixes all the known issues
and should make sata_nv error handling more reliable.

Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/ata/sata_nv.c