]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
drm/radeon: fix deferred page-flip detection logic on Avivo-based ASICs
authorFelix Kuehling <Felix.Kuehling@amd.com>
Fri, 24 Feb 2012 00:16:12 +0000 (19:16 -0500)
committerDave Airlie <airlied@redhat.com>
Wed, 29 Feb 2012 10:23:50 +0000 (10:23 +0000)
commit81ffbbedc37c6043e5f5b123da926aa7dd8ad60a
treef092c02ae2baca58e695f59a3d25f9881dfe43b2
parent884a53ef43eb69dfd48408659b9606e581aee7ba
drm/radeon: fix deferred page-flip detection logic on Avivo-based ASICs

This fixes page-flip-related flickering observed on Iconia Tab W500.

The update_pending status returned by radeon_page_flip is very accurate on
Avivo-based ASICs when vpos is negative.

Experiments were conducted on several ASIC generations ranging from RS690
to Cayman where the page flip was artificially timed to occur at a specific
vpos. With negative vpos, overriding update_pending always lead to
flickering.

The same experiment on RV380 and RV410 showed that update_pending is not
accurate with negative vpos. In most cases update_pending == 1 is returned
although the flip would complete before the start of the next frame.
Therefore I left the behaviour unchanged for pre-AVIVO ASICs for
performance reasons, although this may result in flickering in rare cases.

This change also makes the logic a little easier to understand.

Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com>
Reviewed-by: Mario Kleiner <mario.kleiner@tuebingen.mpg.de>
Signed-off-by: Dave Airlie <airlied@redhat.com>
drivers/gpu/drm/radeon/radeon_display.c