]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
slub: Fix kmem_cache_destroy() with SLAB_DESTROY_BY_RCU
authorEric Dumazet <eric.dumazet@gmail.com>
Thu, 3 Sep 2009 19:38:59 +0000 (22:38 +0300)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 15 Sep 2009 17:37:24 +0000 (10:37 -0700)
commit82b257c06a952cbda39a26012fd7e7978ac0b423
tree9225676bcf3eaa6d7a15ce70fc312bcfae576b8f
parent9579d79f10d42ce275c94b945a3df2f5173d8041
slub: Fix kmem_cache_destroy() with SLAB_DESTROY_BY_RCU

commit d76b1590e06a63a3d8697168cd0aabf1c4b3cb3a upstream.

kmem_cache_destroy() should call rcu_barrier() *after* kmem_cache_close() and
*before* sysfs_slab_remove() or risk rcu_free_slab() being called after
kmem_cache is deleted (kfreed).

rmmod nf_conntrack can crash the machine because it has to kmem_cache_destroy()
a SLAB_DESTROY_BY_RCU enabled cache.

Reported-by: Zdenek Kabelac <zdenek.kabelac@gmail.com>
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
mm/slub.c