]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
switchdev: pass pointer to fib_info instead of copy
authorJiri Pirko <jiri@mellanox.com>
Tue, 17 May 2016 16:58:08 +0000 (18:58 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 24 Jun 2016 17:18:16 +0000 (10:18 -0700)
commit835d0122a57ffaea43162d0e7a4f5bf25d2af78b
tree6ac2447552cf93568d82b65bc69394940776b669
parent6a58f3e12e8e5c330940b38cc8c98d52171aefa8
switchdev: pass pointer to fib_info instead of copy

[ Upstream commit da4ed55165d41b1073f9a476f1c18493e9bf8c8e ]

The problem is that fib_info->nh is [0] so the struct fib_info
allocation size depends on number of nexthops. If we just copy fib_info,
we do not copy the nexthops info and driver accesses memory which is not
ours.

Given the fact that fib4 does not defer operations and therefore it does
not need copy, just pass the pointer down to drivers as it was done
before.

Fixes: 850d0cbc91 ("switchdev: remove pointers from switchdev objects")
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/rocker/rocker.c
include/net/switchdev.h
net/switchdev/switchdev.c