]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
TCP: Fix TCP handling of SACK in bidirectional flows.
authorIlpo Järvinen <ilpo.jarvinen@helsinki.fi>
Wed, 22 Aug 2007 04:18:07 +0000 (21:18 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 31 Aug 2007 06:01:51 +0000 (23:01 -0700)
commit8385cffd22359ad561a173accefeb354bd606ce4
tree88c4bc0dddbd8b41e0d6a90a3030767d5a4aae23
parent783366ad4b212cde069c50903494eb6a6b83958c
TCP: Fix TCP handling of SACK in bidirectional flows.

It's possible that new SACK blocks that should trigger new LOST
markings arrive with new data (which previously made is_dupack
false). In addition, I think this fixes a case where we get
a cumulative ACK with enough SACK blocks to trigger the fast
recovery (is_dupack would be false there too).

I'm not completely pleased with this solution because readability
of the code is somewhat questionable as 'is_dupack' in SACK case
is no longer about dupacks only but would mean something like
'lost_marker_work_todo' too... But because of Eifel stuff done
in CA_Recovery, the FLAG_DATA_SACKED check cannot be placed to
the if statement which seems attractive solution. Nevertheless,
I didn't like adding another variable just for that either... :-)

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/ipv4/tcp_input.c