]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
ipv6: fix a potential deadlock in do_ipv6_setsockopt()
authorWANG Cong <xiyou.wangcong@gmail.com>
Thu, 20 Oct 2016 06:35:12 +0000 (23:35 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 21 Oct 2016 15:29:02 +0000 (11:29 -0400)
commit8651be8f14a12d24f203f283601d9b0418c389ff
tree15f086903cd41889f29e23ac2f80d8bb77f7ead4
parent8dbad1a81128f7e224fce3cce28a1d545d9c0b88
ipv6: fix a potential deadlock in do_ipv6_setsockopt()

Baozeng reported this deadlock case:

       CPU0                    CPU1
       ----                    ----
  lock([  165.136033] sk_lock-AF_INET6);
                               lock([  165.136033] rtnl_mutex);
                               lock([  165.136033] sk_lock-AF_INET6);
  lock([  165.136033] rtnl_mutex);

Similar to commit 87e9f0315952
("ipv4: fix a potential deadlock in mcast getsockopt() path")
this is due to we still have a case, ipv6_sock_mc_close(),
where we acquire sk_lock before rtnl_lock. Close this deadlock
with the similar solution, that is always acquire rtnl lock first.

Fixes: baf606d9c9b1 ("ipv4,ipv6: grab rtnl before locking the socket")
Reported-by: Baozeng Ding <sploving1@gmail.com>
Tested-by: Baozeng Ding <sploving1@gmail.com>
Cc: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Reviewed-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/addrconf.h
net/ipv6/ipv6_sockglue.c
net/ipv6/mcast.c