]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
ext2: use memweight()
authorAkinobu Mita <akinobu.mita@gmail.com>
Sat, 21 Jul 2012 00:54:53 +0000 (10:54 +1000)
committerStephen Rothwell <sfr@canb.auug.org.au>
Wed, 25 Jul 2012 03:53:18 +0000 (13:53 +1000)
commit86cfda1a5cda21217c4b3d39aff2abaa88848f49
treeb71c2221c1a30dc91c2815d26857d49cadc48901
parentd204fed2f9d43c3f50292bacc7f7ee2b2a4f51fe
ext2: use memweight()

Convert ext2_count_free() to use memweight() instead of table lookup based
counting clear bits implementation.  This change only affects the code
segments enabled by EXT2FS_DEBUG.

Note that this memweight() call can't be replaced with a single
bitmap_weight() call, although the pointer to the memory area is aligned
to long-word boundary.  Because the size of the memory area may not be a
multiple of BITS_PER_LONG, then it returns wrong value on big-endian
architecture.

This also includes the following changes.

- Remove unnecessary map == NULL check in ext2_count_free() which
  always takes non-null pointer as the memory area.

- Fix printk format warning that only reveals with EXT2FS_DEBUG.

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Acked-by: Jan Kara <jack@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
fs/ext2/balloc.c
fs/ext2/ialloc.c